Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request - #105 & #103
Description
I updated the
config.yaml
"last updated" information to reflect my updates.Wifi Widget:
I added a new core "wifi' widget to
widgets
andvalidation
. The widget usesos
to get the user's signal strength, then displays said strength in the status bar using nerdfont icons (see image for icons)On left click, the widget also displays the network name. It should be trivial to configure this to display other info, such as current upload/download rate. On right click, the widget opens Windows' network settings.
Weather Widget:
I implemented @zombie-bear's fix, using wttr.in instead of openweathermap.org. I, like zombie-bear, could not get openweathermap to function (possible due to API changes?), but after changing the API request to wttr.in had it working in seconds. I updated the default weather JSON paths to match the old content (temp in C, current condition), as well as the commented explanation in
config.yaml
.Related Issues
Testing
OS: Windows 10 Pro
Komorebi: Yes
Python: 3.11.4
Terminal: Windows PowerShell in Windows Terminal
I ran the updated status bar on two computers in the default configuration (note that the missing icons are due to the default configuation using a nerdfont I don't have installed. This is already the case by default).
I linted the code using pylama (note that all errors seen in the image exist on the current yasb main branch, none of the added code is flagged).
I ran my custom theme with the new widget
I changed the
config.yaml
default options for wifi (eg: icons, update interval)I tried multiple cities using wttr.in and verified the weather against local conditions
All of these performed as expected.